Here’s what I consider to be the basics. I call them that not because they’re easy, but because they’re fundamental. The foundation on which your advanced skills and expertise rest. Multipliers and nullifiers, makers and breakers of everything you do.
Great list! "Never trust a test you've never seen fail" is one of my favourite pieces of dev advice, and I like how you worded your own take 😄
Also enjoyed the ones possibly related to meetings! I'd add "no agenda, no attendance" 😄 If you're putting a meeting together write a clear agenda... so people can do their homework and stand-out, as per your advice!
That's a really good list of things to aim for. I'd augment it with: don't follow instructions blindly, be curious. I believe it is a more general way of saying "know why your fix is a fix".
One thing I personally would add is that before you ask for review all commits are squashed or if there are several commits all of them should make sense and none of them is just WIP that was completely reversed two commits later in the same PR
Absolutely beautiful stuff, distilled to its purest form. Thank you for this
I've organized your points into [this](https://share.cleanshot.com/ck5x1FbQ). I like it even better with this structure.
I've also added the list to a "review my performance against Thorsten's baseline" item for the last Sunday of every March.
this is really wonderful, I shared it to my team
Great list! "Never trust a test you've never seen fail" is one of my favourite pieces of dev advice, and I like how you worded your own take 😄
Also enjoyed the ones possibly related to meetings! I'd add "no agenda, no attendance" 😄 If you're putting a meeting together write a clear agenda... so people can do their homework and stand-out, as per your advice!
That's a really good list of things to aim for. I'd augment it with: don't follow instructions blindly, be curious. I believe it is a more general way of saying "know why your fix is a fix".
Anyway, very good post. I'm recommending it to my friends and in my newsletter too: https://open.substack.com/pub/bitmaybewise/p/abend-dump-9?utm_source=share&utm_medium=android&r=915pz
Amazing.
What do you do when you have colleagues who are missing more than a few of these basics?
One thing I personally would add is that before you ask for review all commits are squashed or if there are several commits all of them should make sense and none of them is just WIP that was completely reversed two commits later in the same PR